Avoid using deprecated NCSARequestLog #16987
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @dreis2211, the lack of tests isn't ideal but that's really our problem. I still think it's worth merging this. Cheers! |
philwebb
pushed a commit
that referenced
this pull request
Jun 2, 2019
philwebb
added a commit
that referenced
this pull request
Jun 2, 2019
wilkinsona
pushed a commit
to wilkinsona/spring-boot
that referenced
this pull request
Jun 4, 2019
wilkinsona
pushed a commit
to wilkinsona/spring-boot
that referenced
this pull request
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
while #16416 migrated away from most of the usages of
NCSARequestLog, it seems to have missed one occurrence inServletManagementChildContextConfiguration.Unfortunately, the parent-child context topic doesn't seem to be covered by a lot of tests and my time is limited at the moment to improve this (outside of this issue). But feel free to not merge this, because of the missing tests.
Cheers,
Christoph